Javascript(Code Reivew) - 01

1. 空对象在数组中不认为是空

// output : this is not empty
if ({}) {
	console.log("this is not empty");
} else {
	console.log("this is empty");
}

2. prefer template 模式

链接地址 : https://eslint.org/docs/rules/prefer-template

// before
const urlPart = Object.keys(params)
	.map(function (k) {
		return encodeURIComponent(k) + "=" + encodeURIComponent(params[k]);
	})
	.join("&");
// after
const urlPart = Object.keys(params)
	.map((k) => {
		const encodeA = encodeURIComponent(k);
		const encodeB = encodeURIComponent(params[k]);
		return `${encodeA}=${encodeB}`;
	})
	.join("&");

3. 不写行内函数 (no-inner-declarations)

链接地址: https://eslint.org/docs/rules/no-inner-declarations

// bad
const handleRender = (h, params) => {
	if (params.row.can_handle === true) {
		function btn(prop) {
			return h('btn', {
				props : prop,
				on    : {
					click : () => {
						that.onDoClick(params);
					}
				}
			});
		}
		let prop = {};
			prop = {
				type  : 'primary',
				icon  : 'ios-compose',
				title : '待提现',
			};
			return btn(prop);
		}
	}
	return '';
}
// good
const handleRender = (h, params) => {
	if (params.row.can_handle === true) {
		let prop = {};
			prop = {
				type  : 'primary',
				icon  : 'ios-compose',
				title : '待提现',
			};
			return h('btn', {
				props : prop,
				on    : {
					click : () => {
						that.onDoClick(params);
					}
				}
			});
		}
	}
	return '';
}

4. 多余的 “,”

// bad
const { status, message, data } = response.data;

// good
const { status, message, data } = response.data;

---

语雀镜像 : Javascript(Code Reivew) - 01 ,点此 提问